This repository was archived by the owner on Feb 24, 2025. It is now read-only.

[Draft] shared web tests #3933

Draft

jonathanKingston wants to merge 28 commits into main from jkt/shared-web-tests

Collaborator

jonathanKingston commented Feb 6, 2025 •

edited

Loading

Task/Issue URL: https://app.asana.com/0/72649045549333/1208763070373634
Tech Design URL:
CC:

Description:

Draft as dependent repo isn't open yet.
Code for that is here: duckduckgo/shared-web-tests@main...jkt/webdriver

Steps to test this PR:
1.
2.

Definition of Done (Internal Only):

Does this PR satisfy our Definition of Done?

Copy Testing:

Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

Portrait
Landscape

Device Testing:

OS Testing:

iOS 15
iOS 16
iOS 17

Theme Testing:

Light theme
Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

jonathanKingston added 11 commits

December 20, 2024 15:27


          Big ol backup

97c7254


          Backup of existing work

8b76ca3


          Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests

39b2b03


          Use launch args and logging


          Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests

7c02f28


          Remove maestro specific changes

f8ec2b4


          Add github workflow

6549f46


          Remove maestro specific setup

9051f24


          Reorder action


          Move changes to extensions

f3ab4cc


          Separate out automation steps into their own methods

3c11508

jonathanKingston requested a review from brindy

February 6, 2025 01:20

github-actions bot commented Feb 6, 2025 •

edited

Loading

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against af83c26

jonathanKingston force-pushed the jkt/shared-web-tests branch 2 times, most recently from 8835f37 to b3bb0a4 Compare

February 6, 2025 09:21


          Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests

7043bf3

jonathanKingston force-pushed the jkt/shared-web-tests branch from b3bb0a4 to 7043bf3 Compare

February 6, 2025 09:24

jonathanKingston added 2 commits

February 6, 2025 10:27


          Remove debug if statements

463ab99


          Remove force try in automation server

d46f947

jonathanKingston commented

View reviewed changes

DuckDuckGo/MainViewController.swift Show resolved Hide resolved

duckduckgo deleted a comment from dailan2009

brindy reviewed

View reviewed changes

DuckDuckGo/AppLifecycle/AppStates/Launching.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift

    
                          case .ready:

                              break // Connection is valid, continue

                          case .cancelled, .failed:

                              print("Connection is no longer valid \(connection.state) \(String(describing: error)) \(String(describing: content)).")

Contributor

brindy Feb 11, 2025

Please replace this print with logging (other places too)

brindy reviewed

View reviewed changes

DuckDuckGo/MainViewController+Automation.swift Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/TabManager.swift Outdated Show resolved Hide resolved


          Rename startAutomationServer to startAutomationServerIfNeeded

8f82b7d

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/AutomationServer.swift Outdated Show resolved Hide resolved

brindy reviewed

View reviewed changes

DuckDuckGo/MainViewController+Automation.swift Outdated Show resolved Hide resolved

jonathanKingston added 9 commits

February 11, 2025 12:02


          Remove making controller public

f05c8d7


          Make AutomationServer final

93ac4df


          Remove stray commented out global connection handler for Automation

7b00a95


          Move currentURL method into direct access within the server

cbcd86f


          Reduce nesting in AutomationServer

e76cd77


          Return early by using guards for error states

4313f26


          Switch object identifiers to use tabModel.uid

2fd77ec


          Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests

8f4a97f


          Merge remote-tracking branch 'origin/main' into jkt/shared-web-tests

784ddb5

jonathanKingston force-pushed the jkt/shared-web-tests branch from 2dda01f to f7ba32d Compare

February 12, 2025 17:47


          Automation fixes

6d71981

jonathanKingston force-pushed the jkt/shared-web-tests branch from f7ba32d to 6d71981 Compare

February 12, 2025 17:54


          Get mainViewController in automation server

ef7df0c

jonathanKingston force-pushed the jkt/shared-web-tests branch from e23c8e8 to d6a3977 Compare

February 13, 2025 16:39


          Simplify configuration of tests

2b558e9

jonathanKingston force-pushed the jkt/shared-web-tests branch from d6a3977 to 2b558e9 Compare

February 13, 2025 16:40


          Move testing steps to npm

af83c26

jonathanKingston mentioned this pull request

Shared web tests duckduckgo/apple-browsers#48

Merged

1 task

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet